Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert: e5b66192 - bring back polymorphism to value formatters #5011

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

danielgindi
Copy link
Collaborator

If anyone does not know how to add a space or change the format in anyway,
please learn how to subclass.

PR Checklist:

  • I have tested this extensively and it does not break any existing behavior.
  • I have added/updated examples and tests for any new behavior.
  • [ ] If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

This is reverting a commit which created a regression in behavior. Specifically, value formatters were not interface based anymore, got ripped of their polymorphism abilities, and lots of functionality was removed by this "little" change.

This is a clean revert.

Sorry, something went wrong.

If anyone does not know how to add a space or change the format in anyway,
please learn how to subclass.
@danielgindi danielgindi merged commit 8c92fcd into PhilJay:master Sep 21, 2020
@danielgindi danielgindi deleted the fix/value_formatter branch September 22, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants